RSA: convert to bin with length in constant time #6896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SparkiDev
force-pushed
the
rsa_to_bin_len_ct
branch
from
178b7e8
to
1877ec2
Compare
Add mp_to_unsigned_bin_len_ct() which puts a number into a buffer with padding in constant time. Call mp_to_unsigned_bin_len_ct() in RSA when encoding result of exponentiation.
SparkiDev
force-pushed
the
rsa_to_bin_len_ct
branch
from
1877ec2
to
fcf1406
Compare
|
retest this please |
JacobBarthelmeh
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add mp_to_unsigned_bin_len_ct() which puts a number into a buffer with padding in constant time.
Call mp_to_unsigned_bin_len_ct() in RSA when encoding result of exponentiation.
Fixes zd#16722
Testing
Standard
Checklist